Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schemas, cleanup, grapple pull icon #147

Conversation

MatthewMarinets
Copy link
Contributor

@MatthewMarinets MatthewMarinets commented Jun 18, 2024

Results of some aimless tinkering this evening:

  • Updated the HERC Grapple pull icon (see below)
  • Some cleanups to RequirementNodeData, BehaviorData, UnitData to get the editor to stop spitting warnings to the console
    • RequirementNodeData no longer uses the SCBW ?token macro thing for some upgrades. It was only used in like 4 places and for one line so I don't really see the point of complicating things like that, and it doesn't play nice with schemas
    • UnitData no longer tries to apply the non-existent stone zealot icons to Fenix's unit/hero icons
    • BehaviorData no longer references the removed
  • Added .xsd schemas to validate RequirementData and RequirementNodeData xml files (edit: and UpgradeData)
  • Some cleanup in UpgradeData:
    • Race tag values updated to match what the editor recognizes ("Terr" and "Prot" instead of "Terran" and "Protoss")

New Icon

image

Schema validation

Catches things like duplicate item IDs, incorrect types, incorrect tags. Requirement and RequirementNode data is pretty simple so it was fun to tinker with, but I doubt I'll do something like this for unit/actor data or anything too complex.
image

Editor cleanup of race field

Old ("Protoss"):
image

New ("Prot"):
image

@Ziktofel Ziktofel merged commit bf235fb into Ziktofel:sc2-next Jun 18, 2024
1 check passed
@MatthewMarinets MatthewMarinets deleted the mm/schemas_cleanup_grapple_pull_icon branch July 15, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants