Awesome WotLK #23
Merged
Awesome WotLK #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built over @FrostAtom library that fully replicates retail nameplates, with proper API and events added.
If library is present in the client, PZ will detect it and use this API to better handle nameplates.
Wow_tWzKVRySO4.mp4
Unfortunately, ElvUI is very intrusive on its nameplate handling with OnUpdate scripts and makes some assumptions that collide with this lib, and hinders 3rd-party implementations. This would be best handled directly on ElvUI Nameplates.lua and oUF... Regardless, PZ will attempt to properly preserve nameplate%d caching.
Another consideration for the future is nuking all unit handling (e.g: NP:SetTargetFrame and NP:SetMouseoverFrame) and only keep nameplate events.