v3 #468
v3 #468
Conversation
Zibbp
commented
Jul 14, 2024
Zibbp
commented
- Remove Temporal and replace with a simpler task system
- Create a 'platform' service
- Platform-specific functions are stored here
- A lot of code refactoring
- Allow defining of "Video" and "Temp" directories
…due to unicode characters. (#467) * Update tdl.go Updated for scenarios where a live comment may be offset due to the presence of unicode characters. * Apply suggestions from code review Applied Zibbp's suggestions. Thank you! Co-authored-by: Isaac <[email protected]> --------- Co-authored-by: Isaac <[email protected]>
internal/utils/file.go
Outdated
| @@ -23,10 +24,58 @@ func CreateFolder(path string) error { | |||
| return nil | |||
There was a problem hiding this comment.
This is still using hardcoded /vods/ (as well as a couple other places in this file).
I tried to archive a video from a new channel, it failed to create the folder (no permissions).
I've set VIDEOS_DIR=/data/vods and TEMP_DIR=/data/temp.
Furthermore, entrypoint.sh tries to chmod /vods, /tmp, etc.
There was a problem hiding this comment.
To clarify, the no permissions is because /vods does not exist and the abc user does not have write for /
There was a problem hiding this comment.
I've updated the hard-coded /vods references with the environment variable. The entrypoint.sh script also now detects and attempts to chmod ... the directories in the env vars. If there are no env vars set it will use the default paths.
I also added options to specify the logs and config directories. Along with making /data/videos the default for vods. Rather make all the breaking changes now.
VideosDir string `env:"VIDEOS_DIR, default=/data/videos"`
TempDir string `env:"TEMP_DIR, default=/data/temp"`
ConfigDir string `env:"CONFIG_DIR, default=/data/config"`
LogsDir string `env:"LOGS_DIR, default=/data/logs"`
- create the temp hls directory during convert - clean up temp hls directory and converted mp4 on video move
