Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: maskClosable of popup not work #1144

Closed
wants to merge 2 commits into from

Conversation

JeromeLin
Copy link
Collaborator

No description provided.

@vercel
Copy link

vercel bot commented Oct 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zarm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2023 8:38am

@github-actions
Copy link

github-actions bot commented Oct 7, 2023

😭 Deploy PR Preview failed.

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (24be772) 90.25% compared to head (8b4c354) 90.22%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1144      +/-   ##
==========================================
- Coverage   90.25%   90.22%   -0.04%     
==========================================
  Files         237      237              
  Lines        5245     5247       +2     
  Branches     1193     1193              
==========================================
  Hits         4734     4734              
- Misses        501      503       +2     
  Partials       10       10              
Files Coverage Δ
packages/zarm/src/popup/Popup.tsx 87.17% <50.00%> (-4.72%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant