Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of PIN deletion with enabled biometrics #1680

Closed
myxmaster opened this issue Sep 21, 2023 · 0 comments · Fixed by #2557
Closed

Fix handling of PIN deletion with enabled biometrics #1680

myxmaster opened this issue Sep 21, 2023 · 0 comments · Fixed by #2557
Labels
Bug Something isn't working Security

Comments

@myxmaster
Copy link
Contributor

Describe the bug

For a good reason, biometrics can only be enabled if a PIN or password is set. But currently you can work around this by deleting the PIN or password after biometrics have been enabled. This leads to not having any fallback in case the finger/face or sensor is lost or damaged (lol).

Instead we should disable biometrics in this case when deleting a PIN or password (and show a warning about this).

Reproduce

Zeus version

v0.8.0

Node interface

LND (REST)

Network

Clearnet

Device

Samsung Galaxy S20+

Device operating system

Android 13

Log output

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working Security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improved security UX and generally enhanced InfoModal myxmaster/zeus
2 participants
@kaloudis @myxmaster