Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved security UX and generally enhanced InfoModal #2557

Conversation

myxmaster
Copy link
Contributor

@myxmaster myxmaster commented Nov 22, 2024

Description

Based on #2554.

InfoModal Enhancements:

  • Added multi-button support with custom buttonTitles and flexible callbacks (including navigation with parameters)
  • Adjusted Text and KeyValue components to work with updated InfoModal
  • Changed infoNav to callback method in Receive

Improved Security UX:

  • Better biometrics setup flow: when user enables biometrics without PIN/password, InfoModal warns with options to create PIN, create password or cancel
    -> if PIN/password is then setup, biometrics is automatically enabled
  • Warning via InfoModal when deleting PIN/password with biometrics enabled, explaining biometrics will be disabled, with options to proceed or cancel -> fixes Fix handling of PIN deletion with enabled biometrics #1680

Additional Improvements:

  • Centered buttons in InfoModal and AlertModal
  • Fixed missing infoLink for AMP explainer in InvoiceSettings
  • Fixed navigation after setting up PIN/password and after deleting password (now it goes to Security instead of Settings)
  • Use popTo('Security') instead of pop(2) for navigating to Security after PIN deletion

grafik
grafik

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • LndHub
  • [DEPRECATED] Core Lightning (c-lightning-REST)
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

views/Settings/SetPin.tsx Outdated Show resolved Hide resolved
@myxmaster myxmaster force-pushed the improved-security-ux-and-generally-enhanced-infoModal branch from a2f07d3 to e66d9d3 Compare November 22, 2024 20:50
locales/en.json Outdated Show resolved Hide resolved
@myxmaster myxmaster force-pushed the improved-security-ux-and-generally-enhanced-infoModal branch from e66d9d3 to 0d30745 Compare November 23, 2024 13:21
kaloudis
kaloudis previously approved these changes Nov 23, 2024
Copy link
Contributor

@kaloudis kaloudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK. Awesome refactor + functionality add

@myxmaster myxmaster dismissed kaloudis’s stale review November 23, 2024 21:46

The merge-base changed after approval.

@kaloudis kaloudis modified the milestones: v0.10.0, v0.9.3 Nov 23, 2024
@kaloudis kaloudis merged commit 99a2d74 into ZeusLN:master Nov 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix handling of PIN deletion with enabled biometrics
2 participants