Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement Semaphore Verifier contract #12

Closed
wants to merge 18 commits into from

Conversation

MPSxDev
Copy link

@MPSxDev MPSxDev commented Nov 6, 2024

Semaphore Verifier contract

📝 Summary

This migrate Semaphore Verifier to Soroban

🔗 Related Issues

🔄 Changes Made

  • Add a new verifier directory for the new contract
  • Add dependencies to the Cargo.toml file
  • Add functions in src/lib.rs

🧪 Testing

Code compile directly as Rust , but not when implemented as a smart contract in Soroban.

🖼️ Screenshots & Resources

✅ Self-Check for Contribution Requirements

Mark with an x all the checkboxes that apply (like [x]).

  • Forked the repository and created a new branch with a meaningful name.
  • Ensured that the content is clear and free of grammatical errors.
  • Maintained consistency in tone and formatting throughout the document.
  • Verified that all links work correctly and checked for typos before submitting the changes.
  • Used the conventional commit format for commit messages.
  • Thoroughly tested changes, including unit tests if applicable.

💬 Comments

The code compiles successfully as Rust, but encounters issues when implemented as a smart contract in Soroban. This presents a significant challenge. Alternative libraries are being tested, but a full solution requires further investigation given the current time constraints.
Several code versions were created using different methods; the latest is still under investigation, requiring additional development time to fully address the issue.

@bitfalt
Copy link
Contributor

bitfalt commented Nov 6, 2024

hiii @MPSxDev, just wondering how you're doing so far and if you are having any problems besides the libraries not working for Soroban.

@evgongora evgongora marked this pull request as ready for review November 6, 2024 12:30
@evgongora
Copy link
Collaborator

Will use this as a reference, Protocol 22 update will now be leveraged. https://github.com/stellar/stellar-protocol/blob/master/core/cap-0059.md

@evgongora evgongora closed this Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Semaphore Integration] Issue 4: Finalize Semaphore Verifier Contract Implementation
3 participants