Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for clang-tidy-17 and cmake 3.27 #101

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 24 additions & 7 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,17 +1,34 @@
FROM ubuntu:23.04
FROM ubuntu:mantic

RUN apt update && \
DEBIAN_FRONTEND=noninteractive \
apt-get install -y --no-install-recommends\
build-essential cmake git \
ARG DEBIAN_FRONTEND=noninteractive

RUN apt update -y && \
apt upgrade -y && \
apt install -y --no-install-recommends \
build-essential \
git \
ca-certificates \
gpg \
wget && \
wget -O - https://apt.kitware.com/keys/kitware-archive-latest.asc 2>/dev/null | gpg --dearmor - | tee /usr/share/keyrings/kitware-archive-keyring.gpg >/dev/null && \
echo 'deb [signed-by=/usr/share/keyrings/kitware-archive-keyring.gpg] https://apt.kitware.com/ubuntu/ jammy main' > /etc/apt/sources.list.d/kitware.list && \
echo 'deb http://apt.llvm.org/mantic/ llvm-toolchain-mantic-17 main' >> /etc/apt/sources.list && \
echo 'deb-src http://apt.llvm.org/mantic/ llvm-toolchain-mantic-17 main' >> /etc/apt/sources.list && \
wget -qO- https://apt.llvm.org/llvm-snapshot.gpg.key | tee /etc/apt/trusted.gpg.d/apt.llvm.org.asc && \
apt update -y && \
rm /usr/share/keyrings/kitware-archive-keyring.gpg && \
apt install -y --no-install-recommends \
kitware-archive-keyring \
cmake \
tzdata \
clang-tidy-13 \
clang-tidy-14 \
clang-tidy-15 \
clang-tidy-16 \
clang-tidy-17 \
python3 \
python3-pip \
&& rm -rf /var/lib/apt/lists/
python3-pip && \
rm -rf /var/lib/apt/lists/*

COPY . /clang_tidy_review/

Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,8 @@ at once, so `clang-tidy-review` will only attempt to post the first
`GITHUB_WORKSPACE`.
- default: `GITHUB_WORKSPACE`
- `clang_tidy_version`: Version of clang-tidy to use; one of
13, 14, 15, 16
- default: '16'
13, 14, 15, 16, 17
- default: '17'
- `clang_tidy_checks`: List of checks
- default: `'-*,performance-*,readability-*,bugprone-*,clang-analyzer-*,cppcoreguidelines-*,mpi-*,misc-*'`
- `config_file`: Path to clang-tidy config file, replaces `clang_tidy_checks`
Expand Down
4 changes: 2 additions & 2 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ inputs:
default: ${{ github.workspace }}
require: false
clang_tidy_version:
description: 'Version of clang-tidy to use; one of 13, 14, 15, 16'
default: '16'
description: 'Version of clang-tidy to use; one of 13, 14, 15, 16, 17'
default: '17'
required: false
clang_tidy_checks:
description: 'List of checks'
Expand Down