Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(network): Upgrade minimum protocol versions for all network kinds #9058

Merged
merged 1 commit into from
Nov 27, 2024
Merged

fix(network): Upgrade minimum protocol versions for all network kinds #9058

merged 1 commit into from
Nov 27, 2024

Conversation

oxarbitrage
Copy link
Contributor

@oxarbitrage oxarbitrage commented Nov 26, 2024 •
edited
Loading

Motivation

Now that Nu6 is activated for Mainnet and Testnet we can drop peers that pre-Nu6.

Close #9045

Solution

Update the minimum protocol version to 170_110 for Testnet and 170_120 for Mainnet.

Tests

Updated tests where needed.

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@oxarbitrage oxarbitrage requested a review from a team as a code owner November 26, 2024 17:38
@oxarbitrage oxarbitrage requested review from arya2 and removed request for a team November 26, 2024 17:38
@oxarbitrage oxarbitrage changed the title fix(network): pgrade min protocol versions for all network kinds fix(network): Upgrade minimum protocol versions for all network kinds Nov 26, 2024
@oxarbitrage oxarbitrage added A-network Area: Network protocol updates or fixes NU-6 Network Upgrade: NU6 specific tasks P-Medium ⚡ labels Nov 26, 2024
arya2
arya2 approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@gustavovalverde
Copy link
Member

@mergify queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 27, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 0af0742

mergify bot added a commit that referenced this pull request Nov 27, 2024
@mergify
Merge of #9058
27de08a
This was referenced Nov 27, 2024
Closed
Merged
Merged
@mergify mergify bot merged commit 0af0742 into main Nov 27, 2024
144 of 145 checks passed
@mergify mergify bot deleted the update-min-betwork-version-nu6 branch November 27, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arya2 arya2 arya2 approved these changes

Assignees
No one assigned
Labels
A-network Area: Network protocol updates or fixes NU-6 Network Upgrade: NU6 specific tasks P-Medium ⚡
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set the minimum network protocol version to 170_110 after NU6 mainnet activation
3 participants
@oxarbitrage @gustavovalverde @arya2