Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color eyre unpin #9031

Closed
wants to merge 2 commits into from
Closed

Conversation

zancas
Copy link
Contributor

@zancas zancas commented Nov 16, 2024

Builds on #9030

Motivation

color-eyre was restricitvely pinned to 0.6.3 which produced conflicts in crate consuming zebra

The goal is to allow consumers using a zebra crate as a dependencies to compile.

Specifications & References

https://doc.rust-lang.org/cargo/reference/resolver.html#semver-compatibility

Solution

By removing the manifest's pin to a specific minor version of the dependency, we allow consumers to find matching dependencies between their dependencies.

Tests

cargo nextest run

Follow-up Work

Allowing consumers flexibility in the dependency set of this workspace will make it more consumable.

I think a reasonable policy might be:

"^n" for n > 0
and

"~0.m" where n == 0.

Fastidious (nightly) runs of cargo update will keep developers aware of how the ecosystem is evolving relative to zebra.

@zancas zancas requested review from a team as code owners November 16, 2024 22:42
@zancas zancas requested review from arya2 and upbqdn and removed request for a team November 16, 2024 22:42
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Nov 16, 2024
@zancas zancas closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant