-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change(consensus): Build Sprout and Sapling parameters into the zebrad binary, so a download server isn't needed #7800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
A-consensus
Area: Consensus rule updates
C-enhancement
Category: This is an improvement
P-Medium ⚡
I-panic
Zebra panics with an internal error message
I-usability
Zebra is hard to understand or use
labels
Oct 23, 2023
https://github.com/ZcashFoundation/zebra/actions/runs/6607410396/job/17944979809?pr=7800#step:4:6196 This is unrelated and will be cleared the next time I push. |
teor2345
changed the title
change(consensus): Build Sprout and Sapling parameters into the zebrad binary
change(consensus): Build Sprout and Sapling parameters into the zebrad binary, so a download server isn't needed
Oct 24, 2023
github-actions
bot
added
the
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
label
Oct 24, 2023
teor2345
removed
I-panic
Zebra panics with an internal error message
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
labels
Oct 24, 2023
github-actions
bot
added
the
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
label
Oct 24, 2023
upbqdn
previously approved these changes
Oct 24, 2023
Co-authored-by: Marek <[email protected]>
upbqdn
previously approved these changes
Oct 24, 2023
teor2345
commented
Oct 24, 2023
teor2345
commented
Oct 24, 2023
teor2345
commented
Oct 24, 2023
teor2345
commented
Oct 24, 2023
teor2345
commented
Oct 24, 2023
upbqdn
approved these changes
Oct 24, 2023
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-consensus
Area: Consensus rule updates
C-enhancement
Category: This is an improvement
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
I-usability
Zebra is hard to understand or use
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We don't want to rely on a single external download server when Zebra first runs.
Close #7613
Close #6963
Fixes known issue in README with parameter downloads
Reduces the size of the full Zebra install and cache on disk by 700 MB (we don't need the full Sprout parameters any more)
This PR series will eventually:
Specifications
This PR is based on the corresponding
zcashd
PR zcash/zcash#6661Complex Code or Requirements
Loading bytes from inside the binary is much simpler, as long as our build disks are large enough. (The final size is smaller because we drop the sprout prover and transcript from the build and binaries.)
Solution
Production code:
CI and testing:
Documentation:
zebrad
's changelog entryTesting
We have existing comprehensive tests for the Sprout and Sapling parameters. Sapling is tested regularly by our integration and sync tests.
Sprout might not be tested, so
Review
This is a routine change, but it is blocking cleanup work in other PRs.
Reviewer Checklist
unsafe code,or consensus rules?Please manually check that the new sprout file contains the correct data. Here is how the
zcashd
team did it:https://github.com/zcash/zcash/pull/6661/files#r1248159359