Renderer basic framework #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackieAnxis
reviewed
Jun 3, 2020
| * @param width canvas width | ||
| * @param height canvas height | ||
| */ | ||
| public constructor(canvas: HTMLCanvasElement, width: number, height: number) { |
There was a problem hiding this comment.
width and height need a default configuration
JackieAnxis
reviewed
Jun 3, 2020
| import { RNode } from './elements/node' | ||
|
|
||
| export class Renderer { | ||
| private gl: WebGL2RenderingContext |
There was a problem hiding this comment.
private variables should be named begin with $_
There was a problem hiding this comment.
All the private properties and private methods are also needed to be named begin with $_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a ...
Description
Self check