Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout from callback #173

Merged
merged 5 commits into from
Nov 21, 2023
Merged

Timeout from callback #173

merged 5 commits into from
Nov 21, 2023

Conversation

matbesancon
Copy link
Member

The timeout was incorrectly handled, the same value was always passed.
Instead, we need to interrupt FW when the total time of Boscia is running out.

The easiest way to do so was through the callback, no timeout should be passed to FW then since we handle it somewhere else

@matbesancon matbesancon requested a review from dhendryc November 21, 2023 14:06
src/node.jl Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (ee5cc6c) 86.23% compared to head (ba95b65) 87.27%.
Report is 10 commits behind head on main.

Files Patch % Lines
src/MOI_bounded_oracle.jl 87.50% 4 Missing ⚠️
src/callbacks.jl 50.00% 4 Missing ⚠️
src/interface.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
+ Coverage   86.23%   87.27%   +1.03%     
==========================================
  Files          17       17              
  Lines        1482     1485       +3     
==========================================
+ Hits         1278     1296      +18     
+ Misses        204      189      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhendryc dhendryc merged commit 0fef819 into main Nov 21, 2023
4 of 5 checks passed
@dhendryc dhendryc deleted the timeout-from-callback branch October 7, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants