-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heuristics Interface #162
Heuristics Interface #162
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
==========================================
+ Coverage 86.23% 87.22% +0.98%
==========================================
Files 17 18 +1
Lines 1482 1620 +138
==========================================
+ Hits 1278 1413 +135
- Misses 204 207 +3 ☔ View full report in Codecov by Sentry. |
We roll the dice on every heuristics, i.e. we can run more than one heuristics at a node. |
We should also think about whether the heuristics should be called at every node or if this should depend on the depth in the tree etc. |
just went over this -> it would be good if a heuristics could return more than one solution as they often create multiple sols. maybe they can return a list or something instead of a single solution. |
Count the calls to the LMO in the heuristcs:
and have a field specifically for the heuristic LMO calls in the TrackingLMO. |
|
The feasibility check after the rounding can become expensive. It would be good to enable the user to set the probability of the rounding to something smaller than 1.0 in case the feasibility check of their LMO is expensive. |
More generically, we can define a property for heuristics, that describes whether they are feasible by design or require a feasibility check, and then a boolean keyword that allows heuristics or not |
you mean of the "standard" rounding -> yes good point. how did you do it before making it a heuristic? |
we have the flag that we return whether feasiblity needs to be checked or not. i set them to zero for those that are guaranteed to be feasible. do we need more? |
No, that's fine. Then we only need a property for the "standard" rounding. |
Interface for our own predefined and user custom heuristics.