Skip to content

Commit

Permalink
Rename SOLVABLE to OPTIMAL.
Browse files Browse the repository at this point in the history
  • Loading branch information
Hendrych committed Oct 24, 2023
1 parent 0cc3fa1 commit 6d0b4d0
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions src/blmo_interface.jl
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ abstract type BoundedLinearMinimizationOracle <: FrankWolfe.LinearMinimizationOr
Enum encoding the status of the Bounded Linear Minimization Oracle.
"""
@enum BLMOStatus begin
SOLVABLE = 0
OPTIMAL = 0
INFEASIBLE = 1
UNBOUNDED = 2
end
Expand Down Expand Up @@ -139,7 +139,7 @@ end
Check if problem is bounded and feasible, i.e. no contradicting constraints.
"""
function check_feasibility(blmo::BoundedLinearMinimizationOracle)
return SOLVABLE
return OPTIMAL
end

"""
Expand Down
2 changes: 1 addition & 1 deletion src/cube_blmo.jl
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ function check_feasibility(blmo::CubeBLMO)
return INFEASIBLE
end
end
return SOLVABLE
return OPTIMAL
end

function is_valid_split(tree::Bonobo.BnBTree, blmo::CubeBLMO, vidx::Int)
Expand Down
4 changes: 2 additions & 2 deletions src/strong_branching.jl
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ function Bonobo.get_branching_variable(
Bonobo.get_branching_indices(tree.root),
)
status = check_feasibility(branching.bounded_lmo)
if status == SOLVABLE
if status == OPTIMAL
empty!(active_set)
for (λ, v) in node.active_set
if v[idx] <= xrel[idx]
Expand Down Expand Up @@ -78,7 +78,7 @@ function Bonobo.get_branching_variable(
Bonobo.get_branching_indices(tree.root),
)
status = check_feasibility(branching.bounded_lmo)
if status == SOLVABLES
if status == OPTIMALS
empty!(active_set)
for (λ, v) in node.active_set
if v[idx] >= xrel[idx]
Expand Down

0 comments on commit 6d0b4d0

Please sign in to comment.