Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing piv settings tests #1400

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fixing piv settings tests #1400

wants to merge 2 commits into from

Conversation

jokkon
Copy link
Contributor

@jokkon jokkon commented Feb 15, 2024

  • refactor most of the utils
  • refactor the settings tests
  • the tests now take heed of ui factory settings ui changes

Please verify that all piv tests function through: flutter test integration_test/piv_test.dart

 - refactor most of the utils
 - refactor the settings tests
 - the tests now take heed of ui factory settings ui changes
Copy link
Member

@AdamVe AdamVe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants