Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add openpgp module #103

Merged
merged 18 commits into from
Sep 25, 2023
Merged

Add openpgp module #103

merged 18 commits into from
Sep 25, 2023

Conversation

AdamVe
Copy link
Member

@AdamVe AdamVe commented Sep 25, 2023

No description provided.

dainnilsson
dainnilsson requested changes Sep 25, 2023
View reviewed changes
openpgp/src/main/java/com/yubico/yubikit/openpgp/OpenPgpSession.java Outdated
Kdf kdf = getKdf();
byte[] data = kdf.process(Pw.USER, newPin);
if (resetCode != null) {
logger.debug("Using Reset Code");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few instances or directly using logger instead of wrapping it in Logger.

@AdamVe AdamVe merged commit c4757c8 into main Sep 25, 2023
3 checks passed
@AdamVe AdamVe deleted the feature/openpgp branch September 25, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dainnilsson dainnilsson dainnilsson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdamVe @dainnilsson