Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fido] Clear sensitive data after use #101

Merged
merged 2 commits into from
Aug 31, 2023
Merged

[fido] Clear sensitive data after use #101

merged 2 commits into from
Aug 31, 2023

Conversation

AdamVe
Copy link
Member

@AdamVe AdamVe commented Aug 28, 2023

Memory containing user provided pin will be cleared after the pin is used/or on error. For BasicWebAuthnClient.ctapMakeCredential and BasicWebAuthnClient.ctapGetAssertions try {} finally {} blocks were added.

@AdamVe AdamVe merged commit cf256b0 into main Aug 31, 2023
3 checks passed
@AdamVe AdamVe deleted the adamve/fido_clear_sensitive_data branch August 31, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dainnilsson dainnilsson dainnilsson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdamVe @dainnilsson