-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added credProps.authenticatorDisplayName #363
Conversation
When will this be merged? 1Password is sending this field and it's failing because of |
@warchildmd : Same here, i'm interested about a merge 👍 |
@warchildmd Which version of |
@emlun : I'm actually using release 2.5.2 and the error is still here : |
Ok, we can fast track a bug fix for that then. Could you please open a new issue and include the full stack trace of the exception? |
My bad, after a deep check, i'm actually using 2.5.1 in my deployed env, i'll update to 2.5.2 and check, thanks for the feedback |
@JDussaussois Did the upgrade fix your problem? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I tweaked the JavaDocs a bit, and while doing that I realized that the new version of the extension is also applicable to assertions, so we need to parse and expose credProps
in ClientAssertionExtensionOutputs
and AssertionResult
too. I'll push those changes on top of this, they're fully analogous to what's here already.
webauthn-server-core/src/main/java/com/yubico/webauthn/RegistrationResult.java
Outdated
Show resolved
Hide resolved
35b4880
to
a1a3e2f
Compare
No description provided.