-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed kvm-ipxe to ipxe-qemu and added source/issue urls #16
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some comment on metadata.rb but I'm 👍
@@ -1,6 +1,8 @@ | |||
name 'kvm' | |||
maintainer 'Guilhem Lettron' | |||
maintainer_email '[email protected]' | |||
source_url 'https://github.com/Youscribe/kvm-cookbook.git' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add if respond_to?(:source_url)
at this end please ? :)
@@ -1,6 +1,8 @@ | |||
name 'kvm' | |||
maintainer 'Guilhem Lettron' | |||
maintainer_email '[email protected]' | |||
source_url 'https://github.com/Youscribe/kvm-cookbook.git' | |||
issues_url 'https://github.com/Youscribe/kvm-cookbook/issues' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add if respond_to?(:issues_url) at this end please ? :)
Changed kvm-ipxe to ipxe-qemu for Ubuntu in attributes/host_tuning.rb.
Also added source_url and issues_url to metadata.rb.
...Uly