Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed font of navbar #177

Merged
merged 11 commits into from
Oct 31, 2022
Merged

changed font of navbar #177

merged 11 commits into from
Oct 31, 2022

Conversation

Mayureshkaulwar
Copy link
Contributor

accept pull request

@YoshithaRathnayake YoshithaRathnayake linked an issue Oct 30, 2022 that may be closed by this pull request
Create a interactive navigation bar #150
Closed
YoshithaRathnayake
YoshithaRathnayake requested changes Oct 30, 2022
View reviewed changes
Copy link
Owner

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the nav more interactive @Mayureshkaulwar

YoshithaRathnayake
YoshithaRathnayake requested changes Oct 30, 2022
View reviewed changes
assets/css/styles.css Outdated Show resolved Hide resolved
@YoshithaRathnayake YoshithaRathnayake added enhancement New feature or request good first issue Good for newcomers labels Oct 30, 2022
YoshithaRathnayake
YoshithaRathnayake requested changes Oct 31, 2022
View reviewed changes
Copy link
Owner

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the nav more interactive

@Mayureshkaulwar
Copy link
Contributor Author

what can I add in navbar like tell me changes you want in navbar

@YoshithaRathnayake
Copy link
Owner

what can I add in navbar like tell me changes you want in navbar

The nav label is sticked to the left side avoid them @Mayureshkaulwar

@Mayureshkaulwar
Copy link
Contributor Author

please merge pull request

@Mayureshkaulwar
Copy link
Contributor Author

Please merge pull request today

@YoshithaRathnayake
Copy link
Owner

Please merge pull request today

I can't bcs I change my whole website @Mayureshkaulwar I can't do that

@YoshithaRathnayake
Copy link
Owner

Now I am going to sleep I can't do anything bcs for our country its 11.00 pm and I am a children and I have to go to school tomorrow. @bhavy2202

YoshithaRathnayake
YoshithaRathnayake requested changes Oct 31, 2022
View reviewed changes
assets/css/styles.css Outdated Show resolved Hide resolved
YoshithaRathnayake
YoshithaRathnayake approved these changes Oct 31, 2022
View reviewed changes
Copy link
Owner

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Merged! @Mayureshkaulwar

@YoshithaRathnayake YoshithaRathnayake merged commit 07d8b27 into YoshithaRathnayake:main Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YoshithaRathnayake YoshithaRathnayake YoshithaRathnayake approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a interactive navigation bar
2 participants
@Mayureshkaulwar @YoshithaRathnayake