Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: switch to Coveralls action runner to upload reports #365

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Nov 24, 2023

Context

  • Simplify CI script

Summary

This PR can be summarized in the following changelog entry:

  • Simplify CI script

Relevant technical choices:

Simplify the code coverage workflow by removing the dependency on the php-coveralls/php-coveralls package and switching to the coverallsapp/github-action action runner, which, as of the release of the 0.6.5 version of the Coverage Reporter now natively supports the Clover format.

The COVERALLS_TOKEN can now be removed from Settings -> Secrets.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • N/A

Simplify the code coverage workflow by removing the dependency on the `php-coveralls/php-coveralls` package and switching to the `coverallsapp/github-action` action runner, which, as of the release of the [0.6.5 version of the Coverage Reporter](https://github.com/coverallsapp/coverage-reporter/releases/tag/v0.6.5) now natively supports the Clover format.

The `COVERALLS_TOKEN` can now be removed from Settings -> Secrets.
@jrfnl jrfnl added yoast cs/qa changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog labels Nov 24, 2023
@jrfnl jrfnl added this to the 3.2 milestone Nov 24, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6985606881

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 14 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.9%) to 57.143%

Files with Coverage Reduction New Missed Lines %
inc/assets.php 1 17.39%
inc/dependencies/dependency-acf.php 1 50.0%
inc/dependencies/dependency-yoast-seo.php 2 60.0%
inc/facade.php 2 0.0%
inc/ac-yoast-seo-acf-content-analysis.php 8 0.0%
Totals Coverage Status
Change from base Build 6925901472: 0.9%
Covered Lines: 172
Relevant Lines: 301

💛 - Coveralls

@jrfnl jrfnl merged commit 7e3872d into develop Nov 24, 2023
9 checks passed
@jrfnl jrfnl deleted the JRF/ghactions-switch-to-coveralls-reporter branch November 24, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog yoast cs/qa
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants