Merge pull request #63 from Yoast/JRF/tests-static-dataproviders

Tests: make dataproviders `static`
Yoast · Sep 23, 2023 · 6de43fc · 6de43fc
2 parents 55643b9 + 153072e
commit 6de43fc
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/tests/BrainMonkey/TestCaseTest.php b/tests/BrainMonkey/TestCaseTest.php
@@ -184,7 +184,7 @@ public function testMakeDoubleForUnavailableClass( $class_name ) {
 	 *
 	 * @return array<string, array<string>>
 	 */
-	public function dataMakeDoubleForUnavailableClass() {
+	public static function dataMakeDoubleForUnavailableClass() {
 		return [
 			'Global class name'                        => [ 'GlobalClassName' ],
 			'Global class name with leading backslash' => [ '\BackslashedClassName' ],
@@ -220,7 +220,7 @@ public function testMakeDoubleForUnavailableClassThrowsExceptionWithInvalidName(
 	 *
 	 * @return array<string, array<string>>
 	 */
-	public function dataMakeDoubleForUnavailableClassThrowsExceptionWithInvalidName() {
+	public static function dataMakeDoubleForUnavailableClassThrowsExceptionWithInvalidName() {
 		return [
 			'Empty string as class name'                       => [ '' ],
 			'Only backslashes'                                 => [ '\\\\\\' ],

diff --git a/tests/BrainMonkey/YoastTestCaseTest.php b/tests/BrainMonkey/YoastTestCaseTest.php
@@ -30,7 +30,7 @@ public function testStubGetBlogInfo( $show, $expected ) {
 	 *
 	 * @return array<string, array<string, string>>
 	 */
-	public function dataStubGetBlogInfo() {
+	public static function dataStubGetBlogInfo() {
 		return [
 			// Explicit cases.
 			'charset' => [
@@ -140,7 +140,7 @@ public function testStubWpParseArgs( $settings, $defaults, $expected ) {
 	 *
 	 * @return array<string, array<string, array<string, mixed>>>
 	 */
-	public function dataStubWpParseArgs() {
+	public static function dataStubWpParseArgs() {
 		return [
 			'two empty arrays' => [
 				'settings' => [],
@@ -221,7 +221,7 @@ public function testStubWpStripAllTags( $text, $remove_breaks, $expected ) {
 	 *
 	 * @return array<string, array<string, string|bool>>
 	 */
-	public function dataStubWpStripAllTags() {
+	public static function dataStubWpStripAllTags() {
 		return [
 			'Empty string' => [
 				'text'          => '',
@@ -284,7 +284,7 @@ public function testStubWpSlash( $input ) {
 	 *
 	 * @return array<string, array<string, mixed>>
 	 */
-	public function dataStubWpSlash() {
+	public static function dataStubWpSlash() {
 		return [
 			'string' => [
 				'input' => "O'Reilly?",
@@ -322,7 +322,7 @@ public function testStubWpUnslash( $input, $expected ) {
 	 *
 	 * @return array<string, array<string, mixed>>
 	 */
-	public function dataStubWpUnslash() {
+	public static function dataStubWpUnslash() {
 		return [
 			'string' => [
 				'input'    => "O\'Reilly\?",

diff --git a/tests/Helpers/ExpectOutputHelperTest.php b/tests/Helpers/ExpectOutputHelperTest.php
@@ -125,7 +125,7 @@ public function testMatchingSubstringsWithMismatchedLineEndingsAmount( $expected
 	 *
 	 * @return array<array<string>>
 	 */
-	public function dataMatchingSubstringsMismatchedLineEndings() {
+	public static function dataMatchingSubstringsMismatchedLineEndings() {
 		return [
 			// Actual line ending type.
 			[ "fox\njumps" ],
@@ -233,7 +233,7 @@ public function testNormalizeLineEndings( $input, $expected ) {
 	 *
 	 * @return array<string, array<string>>
 	 */
-	public function dataNormalizeLineEndings() {
+	public static function dataNormalizeLineEndings() {
 		return [
 			'already-lf'            => [ "foo\n\nbar\n", "foo\n\nbar\n" ],
 			'windows-crlf'          => [ "foo\r\n\r\nbar\r\n", "foo\n\nbar\n" ],