GH Actions: update for branch-cut of PHP 8.4 #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The branch for the new PHP (8.4) version has been cut, which means that PHP "nightly" is now PHP 8.5, so we need to add explicit builds to continue testing against PHP 8.4. Builds against PHP 8.4 should also no longer be allowed to fail as this tool is used in CI, so, even though PHP 8.4 has not been released yet, `8.4` is **not** added to the `continue-on-error` setting. Also see 180 for reasoning about why the explicit PHP 8.4 build is added "early".
jrfnl
force-pushed
the
JRF/ghactions/dont-fail-on-8.4
branch
from
66feedd
to
400a93c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The branch for the new PHP (8.4) version has been cut, which means that PHP "nightly" is now PHP 8.5, so we need to add explicit builds to continue testing against PHP 8.4.
Builds against PHP 8.4 should also no longer be allowed to fail as this tool is used in CI, so, even though PHP 8.4 has not been released yet,
8.4is not added to thecontinue-on-errorsetting.Also see #180 for reasoning about why the explicit PHP 8.4 build is added "early".