Merge branch '2.x' into 3.x

Yoast · Nov 7, 2024 · 7baf347 · 7baf347
2 parents c3c90aa + 1e1fa4c
commit 7baf347
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 14 deletions.
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -20,7 +20,7 @@ jobs:
 
     strategy:
       matrix:
-        php: ['7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', 'nightly']
+        php: ['7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', 'nightly']
 
     continue-on-error: ${{ matrix.php == 'nightly' }}
 

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -20,7 +20,7 @@ jobs:
 
     strategy:
       matrix:
-        php: ['7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3']
+        php: ['7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4']
         phpunit: ['auto']
         coverage: [true]
         experimental: [false]
@@ -101,6 +101,10 @@ jobs:
             phpunit: '11.0.0'
             coverage: true
             experimental: false
+          - php: '8.4'
+            phpunit: '11.3.6'
+            coverage: true
+            experimental: false
 
           # Experimental builds.
           - php: 'nightly'
@@ -113,7 +117,7 @@ jobs:
             experimental: true
 
           - php: 'latest'
-            phpunit: 'dev-main' # PHPUnit 11.x/12.x.
+            phpunit: 'dev-main' # PHPUnit 12.x.
             coverage: false
             experimental: true
 
@@ -234,6 +238,7 @@ jobs:
           # - PHPUnit 8 supports PHP 8.1 as of PHPUnit 8.5.19 (for our purposes).
           # - PHPUnit 8 supports PHP 8.2 as of PHPUnit 8.5.19 (for our purposes).
           # - PHPUnit 8 supports PHP 8.3 as of PHPUnit 8.5.19 (for our purposes).
+          # - PHPUnit 8 supports PHP 8.4 as of PHPUnit 8.5.40 (for our purposes).
           # - PHPUnit 8 does not support running code coverage on PHP 8.0 or higher.
           - php: '7.2'
             phpunit: '8.0'
@@ -245,9 +250,9 @@ jobs:
             coverage: true
           - php: '8.0'
             phpunit: '8.5.12'
-          - php: '8.3'
-            phpunit: '8.5.19'
-          - php: '8.3'
+          - php: '8.4'
+            phpunit: '8.5.40'
+          - php: '8.4'
             phpunit: '8'
 
           # PHPUnit 9 is fully supported for the officially supported PHP versions.
@@ -256,6 +261,7 @@ jobs:
           # - PHPUnit 9 supports PHP 8.1 as of PHPUnit 9.5.8 (for our purposes).
           # - PHPUnit 9 supports PHP 8.2 as of PHPUnit 9.5.8 (for our purposes).
           # - PHPUnit 9 supports PHP 8.3 as of PHPUnit 9.5.8 (for our purposes).
+          # - PHPUnit 9 supports PHP 8.4 as of PHPUnit 9.6.21 (for our purposes).
           - php: '7.3'
             phpunit: '9.0'
             coverage: true
@@ -265,23 +271,21 @@ jobs:
             phpunit: '9.3.0'
           - php: '8.0'
             phpunit: '9'
-          - php: '8.1'
-            phpunit: '9.5.8'
-          - php: '8.1'
-            phpunit: '9'
-          - php: '8.2'
-            phpunit: '9.5.8'
-          - php: '8.2'
-            phpunit: '9'
           - php: '8.3'
             phpunit: '9.5.8'
           - php: '8.3'
             phpunit: '9'
+          - php: '8.4'
+            phpunit: '9.6.21'
+          - php: '8.4'
+            phpunit: '9'
             coverage: true
 
           # PHPUnit 10 is NOT supported in PHPUnit Polyfills 3.x.
 
           # PHPUnit 11 is fully supported for the officially supported PHP versions.
+          # Caveats:
+          # - PHPUnit 11 supports PHP 8.4 as of PHPUnit 11.3.6 (for our purposes).
           #
           # Mind: code coverage can not be run on PHPUnit 11.2.0 - 11.3.2.
           # For a full explanation, see above (in the strategy for the other test job).
@@ -295,6 +299,11 @@ jobs:
           - php: '8.3'
             phpunit: '11'
             coverage: true
+          - php: '8.4'
+            phpunit: '11.3.6'
+          - php: '8.4'
+            phpunit: '11'
+            coverage: true
 
           # Experimental builds.
           - php: 'nightly'