Support python3 & es5 #827
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
November 21, 2016 16:09
Closed
|
I think support for ES5 does already exist now. Is this PR still relevant? |
|
Please, close this PR. It confuses people as @CodingSpiderFox has asked |
ajaywk7
pushed a commit
to freshdesk/elastalert
that referenced
this pull request
Feb 14, 2023
Helm Chart - Expose prometheus metrics to kubernetes prometheus-pod-sd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just found there was support_es5 branch #820 which was created after I forked.
This PR is about just for python3 and es5 support code. I really needed supporting es5 with python3 and finally I tried rough draft about it.
I hope someone would get some help from this. Please someone write some code for compatibility.
Note: