Support timeouts in _request_options #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
analogue
changed the title
added 2 commits
July 24, 2015 15:14
| :param op_kwargs: parameter name/value pairs to pass to the invocation | ||
| of the operation. | ||
| :param op_kwargs: parameter name/value pairs to passed to the | ||
| invocation of the operation. | ||
| :return: request in dict form | ||
| """ | ||
| request_options = op_kwargs.pop('_request_options', {}) |
There was a problem hiding this comment.
Mind adding .copy() here while you're at it?
There was a problem hiding this comment.
Will create another PR to make sure _request_options and headers are not mutated.
There was a problem hiding this comment.
This will fix #160 for bravado.
There was a problem hiding this comment.
Doesn't look like it is an issue in bravado - https://github.com/Yelp/fido/blame/master/fido/fido.py#L171
|
looks good overall. |
…he timeout in HTTPFuture
analogue
added a commit
that referenced
this pull request
Aug 3, 2015
Support timeouts in _request_options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So
_request_optionscurrently only supportsheaders. This adds support fortimeoutandconnect_timeoutto both the Fido and Requests http clients.Fixes issue #165