Pass responses appropriately to errors (swaggerpy) #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpicolo
changed the title
| @@ -26,9 +26,13 @@ def handle_response_errors(e): | |||
| :raises HTTPError: :class: `swaggerpy.exception.HTTPError` | |||
| """ | |||
| args = list(e.args) | |||
| kwargs = {} | |||
| if hasattr(e, 'response') and hasattr(e.response, 'text'): | |||
There was a problem hiding this comment.
Is there value in setting kwargs['response'] even though e.response.text doesn't exist?
There was a problem hiding this comment.
ah, yeah, definitely. fixed
bpicolo
force-pushed
the
support_json_error_responses
branch
from
8d07f5d to
e35602d
Compare
| try: | ||
| handle_response_errors(error) | ||
| except HTTPError as e: | ||
| self.assertEqual(e.json, {'foo': 'bar'}) |
There was a problem hiding this comment.
Where is e.json getting set?
There was a problem hiding this comment.
Ah, that was from previous diff where I had added that as a property to exception. Fixed <3
|
lgtm would be good to have @prat0318 give it a once over since he is more familiar with the codebase. |
bpicolo
force-pushed
the
support_json_error_responses
branch
from
e35602d to
8b56705
Compare
| except HTTPError as e: | ||
| self.assertEqual(e.response.json(), {'foo': 'bar'}) | ||
| self.assertEqual(e.response, response) | ||
| self.assertEqual(e.request, request) |
There was a problem hiding this comment.
I am not sure if there is a test already that '400 Bad Request' is contained in the e's args, will be good to add it if not present already.
|
lgtm |
analogue
added a commit
that referenced
this pull request
Jul 7, 2015
Pass responses appropriately to errors (swaggerpy)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #156 , the main issue being that we actually weren't passing responses to exceptions properly.
e.json might make a good convenience method, but I skipped it for now (e.response.json is a good substitute. But documenting this at some point would be good)