Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/slow binary handling #317

Closed
wants to merge 2 commits into from
Closed

Feature/slow binary handling #317

wants to merge 2 commits into from

Conversation

gp-greg
Copy link

@gp-greg gp-greg commented Feb 11, 2019

This PR adds an optimization for binary responses based on content type. This was originally documented as Issue 394 in the bravado repository.

@macisamuele
Copy link
Collaborator

macisamuele commented Feb 11, 2019

@greenphire-greg thanks a lot for contributing.
NOTE: this is a quick first pass (did not check all the details)

Checking at the issue and at your PR I have a couple of suggestions

  • bravado unmarshaling is performed here and not in bravado-core (probably the bravado-core is some dead code that we should eventually remove)
  • I would suggest to avoid to mark all the possible mime types that reflect binary formats as this is not scalable.
    Maybe changing the "default" response type would be an option (even thought I'm not sure), an other option to overcome the scalability issue could be to add a configuration that lists all the mime types that need to return response.raw_bytes
  • please install the hooks on your repository such that you can easily fix the travis failure (make install-hooks)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 98.466% when pulling a987342 on Greenphire:feature/slow-binary-handling into 18e3574 on Yelp:master.

@gp-greg
Copy link
Author

gp-greg commented Feb 11, 2019

Alright, I'll close this and resubmit to the bravado repo.

@gp-greg gp-greg closed this Feb 11, 2019
@gp-greg gp-greg deleted the feature/slow-binary-handling branch February 11, 2019 19:17
@macisamuele
Copy link
Collaborator

@greenphire-greg thanks for the understanding and for helping us in making the tool better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants