Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a test failing on some cultures #268

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

praschl
Copy link

@praschl praschl commented Feb 13, 2024

  • Tests for the changes have been added (for bug fixes / features)
    • Does it pass all existing unit tests without modification?
  • CHANGELOG.md has been updated to describe this change

The test "VariableStorage_OnExternalChanges_ReturnsExpectedValue" failed when run on computers with german culture (and probably other cultures) because they format floats & decimals as "3,52", when the test expected "3.52"

Fixed by preformatting the expected values in the same culture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant