Skip to content

Commit

Permalink
Remove 'Convert Implicit Declarations' button temporarily
Browse files Browse the repository at this point in the history
This feature will be re-implemented when
YarnProject.AddYarnFunctionMethodsToLibrary has been implemented.
  • Loading branch information
desplesda committed Aug 17, 2021
1 parent 2ffd47c commit d53a508
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

### Removed

* Yarn Programs: The 'Convert Implicit Declarations' button has been temporarily removed, due to a required compatibility change related to the new type system. It will be restored before final 2.0 release.

## [v2.0.0-beta3] 2021-03-27

### Added
Expand Down
5 changes: 5 additions & 0 deletions Editor/Editors/YarnProjectImporterEditor.cs
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,10 @@ public override void OnInspectorGUI()

serializedDeclarationsList.DrawLayout();

// The 'Convert Implicit Declarations' feature has been
// temporarily removed in v2.0.0-beta5.

#if false
// If any of the serialized declarations are implicit, add a
// button that lets you generate explicit declarations for them
var anyImplicitDeclarations = false;
Expand All @@ -96,6 +100,7 @@ public override void OnInspectorGUI()
return;
}
}
#endif

EditorGUILayout.PropertyField(defaultLanguageProperty, new GUIContent("Default Language"));

Expand Down
4 changes: 2 additions & 2 deletions Runtime/YarnProject.cs
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ public Program GetProgram()
}

public static void AddYarnFunctionMethodsToLibrary(Library library, params System.Reflection.Assembly[] assemblies) {
Debug.Log($"{nameof(AddYarnFunctionMethodsToLibrary)} is not currently implemented, and is a no-op.");
return;
throw new System.NotImplementedException($"{nameof(AddYarnFunctionMethodsToLibrary)} is not currently implemented, and is a no-op.");

if (assemblies.Length == 0) {
assemblies = System.AppDomain.CurrentDomain.GetAssemblies();
}
Expand Down

0 comments on commit d53a508

Please sign in to comment.