Strip the BOM from the source string if it is present #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… present to bring it inline with how the C# lib works
|
Resolves #191 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the Yarn Docs say they only accept UTF-8 the examples in the C# repos have yarn files using a UTF-8 with BOM encoding. This does not mess with them as C# will strip the BOM when reading the file as text. Rust though does not do this by default, instead reading it in as a character which causes compilation failures or sometimes panics to occur.
rust-lang/rfcs#2428
This change adds a quick sanitation step when processing the files to strip the BOM from the file if it is present to line the expected behavior up with the core Yarn Spinner lib.