Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for CI #190

Merged
merged 4 commits into from
May 17, 2024
Merged

Fixes for CI #190

merged 4 commits into from
May 17, 2024

Conversation

stargazing-dino
Copy link
Contributor

@stargazing-dino stargazing-dino commented May 4, 2024 •
edited
Loading

Fixes CI for new lints

https://rust-lang.github.io/rust-clippy/master/#/redundant_clone

and some more unused code that wasn't being caught before.

(I always forget to run rustup so it's surprising to see difference in CI and locally haha)

@stargazing-dino stargazing-dino changed the title Remove unused StrRefExt trait Fixes for CI May 4, 2024
janhohenheim
janhohenheim approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@janhohenheim janhohenheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)
I'm a bit confused about add_error_node not being used. Maybe I made some mistake somewhere.

@janhohenheim janhohenheim merged commit 3ba3cb8 into YarnSpinnerTool:main May 17, 2024
4 checks passed
@stargazing-dino stargazing-dino deleted the remove_unused branch May 17, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janhohenheim janhohenheim janhohenheim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stargazing-dino @janhohenheim