Fix dialogue variables not mimicking actual narrative variables #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Eh will look into that test later. And possibly add my own regression one |
|
Idea sounds sound to me. I'll check the PR in detail when you're done :) |
* Remove unused StrRefExt trait * redundant_clone * Unused code
stargazing-dino
force-pushed
the
extend_with_declarations
branch
from
d3d2df2 to
9950c19
Compare
This reverts commit d107f63.
|
Heh I found out why that test was erroring: .declare_variable(
Declaration::new("$external_str", Type::String).with_default_value("Hello"),
)
.declare_variable(Declaration::new("$external_int", Type::Boolean).with_default_value(true)) // <--
.declare_variable(Declaration::new("$external_bool", Type::Number).with_default_value(42)) // <--I also added a test to validate declared vars are indeed visible ^^ Other CI failures I think are unrelated |
|
@stargazing-dino hehe, that one seems sneaky |
|
Hmm, I'm missing the "merge main branch into this branch" button here and your other PR. Could you merge |
|
should be ready now |
janhohenheim
requested changes
May 17, 2024
|
Thanks :) |
janhohenheim
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dialogue.variable_storage().variables()will also havedeclare'd variables as well now.