Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add no program loaded error #181

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Add no program loaded error #181

merged 1 commit into from
Feb 21, 2024

Conversation

stargazing-dino
Copy link
Contributor

Trying to avoid more runtime panics when running dialogue

janhohenheim
janhohenheim approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@janhohenheim janhohenheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch for converting all these panics into propagated errors, I really appreciate it :)

@janhohenheim janhohenheim merged commit 9712d96 into YarnSpinnerTool:main Feb 21, 2024
4 checks passed
@stargazing-dino stargazing-dino deleted the no_program_error branch February 21, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janhohenheim janhohenheim janhohenheim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stargazing-dino @janhohenheim