Skip to content
This repository has been archived by the owner on Jul 15, 2019. It is now read-only.

Add some options (videos handling, layout and selection ordering) #29

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

zepojo
Copy link

@zepojo zepojo commented Jan 10, 2017

This makes the component more customizable, by allowing the user to change some options.
These options can be set through a configuration proxy (YMSPhotoPickerConfiguration) and are the following:

  • sourceType: the type of media that can be browsed, captured and selected by the user. This makes YMSPhotoPicker compatible with videos.
  • numberOfColumns: the number of columns of thumbnails visible when browsing the gallery.
  • sortingType: the way selected medias are sorted in the delegate callback method, and the kind of check displayed on every selected cell (check mark or label of the order).

I don't know if the fact that the component was only compatible with photos was what's intended, but the video compatibility can make it more powerful.
Every part of the lib been adapted (grid cells, preview screen, camera mode and delegate methods).
The default options make the component act just like it is today.

@yahoocla
Copy link

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄

@yahoocla
Copy link

CLA is valid!

@fryette
Copy link

fryette commented Sep 12, 2018

@ink-spot could you please fix merge request?
I would like to port it to the xamarin binding library.
Thx in advance

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants