This repository has been archived by the owner on Jul 15, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 97
Add some options (videos handling, layout and selection ordering) #29
Open
zepojo
wants to merge
17
commits into
YahooArchive:master
Choose a base branch
from
zepojo:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e documentation & Readme
Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄 |
CLA is valid! |
@ink-spot could you please fix merge request? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the component more customizable, by allowing the user to change some options.
These options can be set through a configuration proxy (
YMSPhotoPickerConfiguration
) and are the following:sourceType
: the type of media that can be browsed, captured and selected by the user. This makesYMSPhotoPicker
compatible with videos.numberOfColumns
: the number of columns of thumbnails visible when browsing the gallery.sortingType
: the way selected medias are sorted in the delegate callback method, and the kind of check displayed on every selected cell (check mark or label of the order).I don't know if the fact that the component was only compatible with photos was what's intended, but the video compatibility can make it more powerful.
Every part of the lib been adapted (grid cells, preview screen, camera mode and delegate methods).
The default options make the component act just like it is today.