Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added plugin YOURLS-Custom-Header name #185

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

srivastava07
Copy link
Contributor

This plugin enables the addition of a custom header to the URL, facilitating compliance with regulatory requirements in certain countries, such as India, for bulk SMS services. Pass custom_header in query param to add custom header as prefix to the generated short url

Copy link
Member

@LeoColomb LeoColomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this pull request, @srivastava07.
Let's make the name a bit more readable.
Also, don't hesitate to add a license file to your project to ease its use and open it for contributions. https://github.com/srivastava07/YOURLS-Custom-Header/community/license/new?branch=main

README.md Outdated Show resolved Hide resolved
Co-authored-by: Léo Colombaro <[email protected]>
@srivastava07
Copy link
Contributor Author

@LeoColomb I have added the LICENSE file, Thanks for the suggestion.

Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how this prefix counts as a "header", but the addition here looks fine assuming that users who know (and need) what this does will recognize it in the list.

@LeoColomb LeoColomb merged commit d7a4d28 into YOURLS:main Nov 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants