refactor: 회원가입 시 닉네임 유효성 검사 오류 개선 #82

YAPP-Github · Jul 25, 2022 · 4d6480a · 4d6480a
1 parent f9adff5
commit 4d6480a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/Weekand/Weekand/Presentation/SignScene/SignUp/View/SignUpAddInfomationViewController.swift b/Weekand/Weekand/Presentation/SignScene/SignUp/View/SignUpAddInfomationViewController.swift
@@ -137,16 +137,14 @@ extension SignUpAddInfomationViewController: UICollectionViewDelegate {
     func collectionView(_ collectionView: UICollectionView, shouldSelectItemAt indexPath: IndexPath) -> Bool {
         if collectionView == jobStackView.collectionView {
             if let jobs = jobStackView.collectionView.indexPathsForSelectedItems,
-               jobs.count <= 2
-            {
+               jobs.count <= 2 {
                 return true
             } else {
                 return false
             }
         } else {
             if let interests = interestsStackView.collectionView.indexPathsForSelectedItems,
-               interests.count <= 2
-            {
+               interests.count <= 2 {
                 return true
             } else {
                 return false

diff --git a/Weekand/Weekand/Presentation/SignScene/SignUp/View/SignUpViewController.swift b/Weekand/Weekand/Presentation/SignScene/SignUp/View/SignUpViewController.swift
@@ -136,7 +136,7 @@ class SignUpViewController: BaseViewController {
             } else {
                 self?.emailStackView.setInformlabelText(string: "유효한 이메일입니다", informType: .vaild)
             }
-        })
+        }).disposed(by: disposeBag)
 
         output.checkAuthenticationNumber.subscribe(onNext: { [weak self] isCheck in
             if isCheck {

diff --git a/Weekand/Weekand/Presentation/SignScene/SignUp/ViewModel/SignUpViewModel.swift b/Weekand/Weekand/Presentation/SignScene/SignUp/ViewModel/SignUpViewModel.swift
@@ -143,7 +143,7 @@ class SignUpViewModel: ViewModelType {
     }
 
     private func vaildNickname(_ nickName: String) -> (String, Bool) {
-        if nickName.count >= 2 && nickName.count < 11 {
+        if nickName.count >= 2 && nickName.count < 13 {
             return (nickName, true)
         }
         return (nickName, false)