Skip to content

Commit

Permalink
YJIT: Disable static_mut_refs for now
Browse files Browse the repository at this point in the history
  • Loading branch information
XrXr committed Dec 11, 2024
1 parent 019d033 commit 38c33b1
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions yjit/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,17 @@
#![allow(clippy::too_many_arguments)] // :shrug:
#![allow(clippy::identity_op)] // Sometimes we do it for style

// TODO(alan): This lint is right -- the way we use `static mut` is UB happy. We have many globals
// and take `&mut` frequently, sometimes with a method that easily allows calling it twice.
//
// All of our globals rely on us running single threaded, which outside of boot-time relies on the
// VM lock (which signals and waits for all other threads to pause). To fix this properly, we should
// gather up all the globals into a struct to centralize the safety reasoning. That way we can also
// check for re-entrance in one place.
//
// We're too close to release to do that, though, so disable the lint for now.
#![allow(static_mut_refs)]

pub mod asm;
mod backend;
mod codegen;
Expand Down

0 comments on commit 38c33b1

Please sign in to comment.