Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 / ♻️ Fix Node Cross Canvas Pasting + Enable Reload for Parameter Nodes #359

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

MFA-X-AI
Copy link
Member

Description

Currently when a node is pasted from another canvas, the inPort type will be "" due to an unimplemented deserialization method. The simplest way around this is to simply trigger a reload on the pasted node which refetches the node information. While implementing this, I've also enabled reload to be used on parameter nodes, which was previously disabled due to it crashing the interface when reloaded.

References

#251

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Xircuits Project Template
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  1. Copy paste a node from one canvas to another. Connect a literal / argument to it. Verify that it can be correctly connected.
  2. Trigger a reload on a parameter component / using reload all. Verify that on the console window, it doesn't log that Literals / Arguments cannot be reloaded.

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Copy link

Binder 👈 Launch a binder notebook on branch XpressAI/xircuits/fahreza/fix-cross-paste

@MFA-X-AI MFA-X-AI merged commit e3876c3 into master Oct 21, 2024
9 checks passed
@MFA-X-AI MFA-X-AI deleted the fahreza/fix-cross-paste branch October 21, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant