Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create functions instead of extending String prototype #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JoshuaCWebDeveloper
Copy link

I don't believe the ease of having a string method justifies the risk of extending a native type in this case, and it was breaking another library with bugs that were very hard to diagnose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant