Modularize css-to-pdf #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've rewritten css-to-pdf to be able to be imported as a module in various environments.
The largest changes where whitespace/formatting changes. Indentation was currently a mix of tabs, 4-spaces, and 2-spaces, so I replaced all the tabs with 4-spaces to be more consistent. Also, wrapping the existing code in a function made it necessary to indent everything. These two major formatting changes are in their own commits.
I've also created a package.json file which will allow users to install this via npm as
Xportability/css-to-pdf. This is also most of the work needed for Issue #31, all that is needed after this is to follow the steps in https://docs.npmjs.com/getting-started/publishing-npm-packages. The version number should be updated when future changes are "released."This PR should not affect any current users; css-to-pdf can still be included in a
<script>tag to create the globalxepOnlinevariable as is currently documented.