Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2_2] add blackbox_test #41

Merged
merged 2 commits into from
Aug 10, 2023
Merged

[2_2] add blackbox_test #41

merged 2 commits into from
Aug 10, 2023

Conversation

Yuanmxc
Copy link
Contributor

@Yuanmxc Yuanmxc commented Aug 7, 2023

No description provided.

@Yuanmxc Yuanmxc closed this Aug 7, 2023
@Yuanmxc Yuanmxc reopened this Aug 7, 2023
@Yuanmxc Yuanmxc force-pushed the addTest branch 2 times, most recently from 7318d53 to 220a402 Compare August 7, 2023 10:00
@Charonxin
Copy link
Collaborator

Charonxin commented Aug 8, 2023

是这样,可能doctest在某些平台会产生冲突,,遇到过类似问题,检查get_type函数的话还是用那个Joris爹写好的open_box比较好,多了二十多行代码什么的。。而且这个里面的ASSERT抛异常走的是cout,就算有异常也不会影响CI(狗头保命)。。

另外如果非要用C++枚举那个基础类型的话,我试了那种迭代temple的方法,但是没有成功,后面可以再讨论下。。
71e5db834f25835255a01175fb5e92a

@Yuanmxc
Copy link
Contributor Author

Yuanmxc commented Aug 9, 2023

是这样,可能doctest在某些平台会产生冲突,,遇到过类似问题,检查get_type函数的话还是用那个Joris爹写好的open_box比较好,多了二十多行代码什么的。。而且这个里面的ASSERT抛异常走的是cout,就算有异常也不会影响CI(狗头保命)。。

另外如果非要用C++枚举那个基础类型的话,我试了那种迭代temple的方法,但是没有成功,后面可以再讨论下。。 71e5db834f25835255a01175fb5e92a

那个异常应该是有影响的,在这里,很抱歉,今天有事耽搁,明天我去改。

@Charonxin
Copy link
Collaborator

是这样,可能doctest在某些平台会产生冲突,,遇到过类似问题,检查get_type函数的话还是用那个Joris爹写好的open_box比较好,多了二十多行代码什么的。。而且这个里面的ASSERT抛异常走的是cout,就算有异常也不会影响CI(狗头保命)。。
另外如果非要用C++枚举那个基础类型的话,我试了那种迭代temple的方法,但是没有成功,后面可以再讨论下。。 71e5db834f25835255a01175fb5e92a

哪个异常应该是有影响的,在这里,我抱歉,今天有事耽搁,明天我去改。

那就是我看错了,会throw的hhh,抱歉

@Yuanmxc Yuanmxc marked this pull request as ready for review August 10, 2023 04:05
@Charonxin Charonxin merged commit 6e951ec into XmacsLabs:main Aug 10, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants