-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8_12] improve strategy of expanding string for performance #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmance" This reverts commit d4cfb60.
bench的结果在Pull Request的描述里面贴一下吧 |
依据PR里面的描述,前三项的性能退化了。 |
da-liii
reviewed
Jul 13, 2024
在第三次提交下,性能应该有改善,需要一个新的性能对比,来判断性能上是否提升或者降低。 |
已更新在pr的说明中 |
slice/concat/append 变快了,别的基本上差不多,略有变慢 |
这是之前的代码:30170ac |
在PR描述或者代码里面写一下,这个pr和 #331 有什么区别,如何做到避免内存问题的 |
da-liii
approved these changes
Jul 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
da-liii
changed the title
Jingkaimori/string backport
[8_12] improve strategy of expanding string for performance
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr ensure the layout consistency between array and string, by make member pointer appears at the same position of class, so that union inside tree will not be broken.
#331
this pr
Performance
Before
construct string
equality of string
equality of larger string
compare string
compare larger string
slice string
slice string with larger range
concat string
append string
hash of string
hash of larger string
is quoted
After
construct string
equality of string
equality of larger string
compare string
compare larger string
slice string
slice string with larger range
concat string
append string
hash of string
hash of larger string
is quoted