Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8_11] add binary_to_hexadecimal interface #335

Merged
merged 2 commits into from
Jun 11, 2024
Merged

[8_11] add binary_to_hexadecimal interface #335

merged 2 commits into from
Jun 11, 2024

Conversation

jingkaimori
Copy link
Contributor

Performance

9x faster than legacy algorithm

relative ns/op op/s err% total benchmark
100.0% 741,626.67 1,348.39 0.6% 0.11 convert document to hexadecimal string, legacy
1,107.8% 66,947.70 14,937.03 1.0% 0.11 convert document to hexadecimal string, using binary_to_hexadecimal

@jingkaimori jingkaimori requested a review from da-liii June 10, 2024 09:27
@da-liii da-liii changed the title add binary_to_hexadecimal interface [8_11] add binary_to_hexadecimal interface Jun 11, 2024
da-liii
da-liii approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@da-liii da-liii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@da-liii da-liii merged commit 64be652 into main Jun 11, 2024
12 checks passed
@da-liii da-liii deleted the jingkaimori/string-algorithm branch June 11, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@da-liii da-liii da-liii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jingkaimori @da-liii