This repository has been archived by the owner on Nov 8, 2024. It is now read-only.
example: add Dip origin checks to NFT marketplace place #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntn-x2
commented
Jul 29, 2024
| @@ -250,30 +241,25 @@ pub mod pallet { | |||
| /// The maximum length of data stored in for post codes. | |||
| #[pallet::constant] | |||
| type PostcodeLimit: Get<u32>; | |||
|
|
|||
| type DidIdentifier: Parameter + MaxEncodedLen; | |||
There was a problem hiding this comment.
This type could also be hardcoded somewhere else instead of being a type parameter of this crate.
ntn-x2
commented
Jul 29, 2024
| @@ -250,30 +241,25 @@ pub mod pallet { | |||
| /// The maximum length of data stored in for post codes. | |||
| #[pallet::constant] | |||
| type PostcodeLimit: Get<u32>; | |||
|
|
|||
| type DidIdentifier: Parameter + MaxEncodedLen; | |||
| type BuyTokenOrigin: EnsureOrigin<Self::RuntimeOrigin, Success = Self::DidIdentifier>; | |||
There was a problem hiding this comment.
This will most likely be a more generic origin rather than an origin for a specific call. What's important is the trait it's required to implement, and the expected Success type, which will be a Kilt DID.
ntn-x2
commented
Jul 29, 2024
| @@ -702,16 +656,15 @@ pub mod pallet { | |||
| #[pallet::call_index(3)] | |||
| #[pallet::weight(<T as pallet::Config>::WeightInfo::buy_token())] | |||
| pub fn buy_token(origin: OriginFor<T>, listing_id: u32, amount: u32) -> DispatchResult { | |||
| let origin = ensure_signed(origin.clone())?; | |||
| // You have access to the DID origin now. | |||
There was a problem hiding this comment.
This is the other relevant change, which gives the extrinsic access to the DID of the submitter.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An example of how the DIP consumer can be integrated into a pallet. With the origin check added to the pallet's config, it's possible to get access to the DID identifier of the submitter.
The flow would then be:
pallet_dip_consumer.dispatchAsextrinsic on the Xcavate chain with the right call.