Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-segment explicitly when user passes config variable #36

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Re-segment explicitly when user passes config variable #36

wants to merge 3 commits into from

Conversation

XachaB
Copy link
Owner

@XachaB XachaB commented Sep 2, 2024

Here's an attempt at fixing #35

JPapir
JPapir reviewed Sep 2, 2024
View reviewed changes
src/qumin/config/qumin.yaml Outdated Show resolved Hide resolved
@JPapir
Copy link
Collaborator

JPapir commented Sep 2, 2024

I do not see anything surprising, but I do not master very well the phonology & pattern part of Qumin, so I'm maybe not a great help

@XachaB
Copy link
Owner Author

XachaB commented Sep 2, 2024

Thanks, you're still spotting issues :)

Todo;

  • Check the behaviour with some tests

@JPapir JPapir mentioned this pull request Dec 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JPapir JPapir JPapir left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XachaB @JPapir