Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/add requests dependency #32

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Bugfix/add requests dependency #32

merged 3 commits into from
Sep 25, 2024

Conversation

NacerKaciXXII
Copy link
Collaborator

Hi!

This PR:

  • Fixes add requests dependency to the non-extra package because it is imported by schema_utils_functions.py but is only installed with the extra fiftyone
  • Fixes the tutorials url in the README

@NacerKaciXXII NacerKaciXXII self-assigned this Sep 25, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

ClementPinard
ClementPinard approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@ClementPinard ClementPinard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@NacerKaciXXII NacerKaciXXII merged commit 0fe2ca4 into main Sep 25, 2024
14 checks passed
@NacerKaciXXII NacerKaciXXII deleted the bugfix/add_requests_dependency branch September 25, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClementPinard ClementPinard ClementPinard approved these changes

Assignees

@NacerKaciXXII NacerKaciXXII

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NacerKaciXXII @ClementPinard