Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Coin Space Wallet #2321

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Add Coin Space Wallet #2321

merged 1 commit into from
Feb 2, 2024

Conversation

mahnunchik
Copy link
Contributor

This PR adds Coin Space wallet to list of Software Wallets.

Notes:

  1. Styles are not compiled yarn run build-css because it produces a lot of not related changes.
  2. String translations are not updated pybabel extract -F ./locale/babel.cfg -o ./locale/messages.pot ./ because there are a lot of not related changes changes.

@mahnunchik
Copy link
Contributor Author

Could I ask for the review? @mDuo13 @oeggert

@oeggert oeggert self-assigned this Jan 20, 2024
@intelliot
Copy link
Contributor

I don't see XRP mentioned on the https://coin.space/ homepage (even though other digital assets are there). Maybe it supports XRP but it is not clear/obvious... and of course I have no personal knowledge or experience of Coin Space.

@mahnunchik
Copy link
Contributor Author

@intelliot could you please check it again, this is step by step guide:

  1. Make sure your internet connection is turned on
  2. Open the website https://coin.space/
  3. Navigate to menu item named Wallet
  4. Open the link https://coin.space/xrp-wallet/

Or you can visit Features page https://coin.space/features/

xrp

@amarantha-k amarantha-k merged commit 89034c9 into XRPLF:master Feb 2, 2024
3 checks passed
@amarantha-k
Copy link
Collaborator

Thank you for your contribution, @mahnunchik!
Also, for your reference, the underlying toolchain is being migrated to Redocly. I've cherry-picked your changes to be included in the migrated site (PR #2372).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants