Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds new events to community and events page #2303

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Conversation

AKCodez
Copy link
Contributor

@AKCodez AKCodez commented Dec 13, 2023

No description provided.

Copy link

Link check report. 579093 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/events-updates-12/12/23/

Style Report

Copy link
Collaborator

@mDuo13 mDuo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, although we might want to revisit the events carousel on the Community page. It's painfully slow to rotate new things in, IMO, and the images for the non-focused events are not useful, so it's basically pointless except for whatever event is the default highlighted one. (I'm not sure why it's still showing the XRPL Community Report Launch Party, which is in the past, as the default one.)

@@ -433,17 +433,64 @@
"image": "paris.png",
"end_date": "November 28, 2023"
},
# { "name": "XRP Ledger Zone ETHDenver",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer not to clutter up files with commented-out draft data.

@AKCodez
Copy link
Contributor Author

AKCodez commented Dec 14, 2023

Looks fine, although we might want to revisit the events carousel on the Community page. It's painfully slow to rotate new things in, IMO, and the images for the non-focused events are not useful, so it's basically pointless except for whatever event is the default highlighted one. (I'm not sure why it's still showing the XRPL Community Report Launch Party, which is in the past, as the default one.)

I will revisit this logic and refine it once we migrate it to redocly.

@AKCodez AKCodez merged commit ca0c678 into master Dec 14, 2023
3 of 4 checks passed
@mDuo13 mDuo13 deleted the events-updates-12/12/23 branch December 14, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants